Add a default password reset token to has_secure_password #52483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Unrelated failures. |
excid3
reviewed
Aug 2, 2024
| # Only generate tokens for records that are capable of doing so (Active Records, not vanilla Active Models) | ||
| if reset_token && respond_to?(:generates_token_for) | ||
| generates_token_for :"#{attribute}_reset", expires_in: 15.minutes do | ||
| public_send(:"#{attribute}_salt")&.last(10) |
There was a problem hiding this comment.
@dhh does this mean we'll need password_digest and password_salt columns?
There was a problem hiding this comment.
password_digest is already generated in the migration and salt is virtual.
4 tasks
abeidahmed
added a commit
to abeidahmed/rails
that referenced
this pull request
Sep 1, 2024
Extends rails#52483 Ability to change the default `expires_in` for `has_secure_password` token generator. ```ruby class User < ApplicationRecord has_secure_password reset_password_token_expires_in: 30.minutes end ```
abeidahmed
added a commit
to abeidahmed/rails
that referenced
this pull request
Sep 1, 2024
Extends rails#52483 Ability to change the default `expires_in` for `has_secure_password` token generator. ```ruby class User < ApplicationRecord has_secure_password reset_token_expires_in: 30.minutes end ```
4 tasks
abeidahmed
added a commit
to abeidahmed/rails
that referenced
this pull request
Sep 13, 2024
Extends rails#52483 Ability to change the default `expires_in` for `has_secure_password` token generator. ```ruby class User < ApplicationRecord has_secure_password reset_token: { expires_in: 30.minutes } end ```
abeidahmed
added a commit
to abeidahmed/rails
that referenced
this pull request
Oct 1, 2024
Extends rails#52483 Ability to change the default `expires_in` for `has_secure_password` token generator. ```ruby class User < ApplicationRecord has_secure_password reset_token: { expires_in: 30.minutes } end ```
DanielaVelasquez
pushed a commit
to DanielaVelasquez/rails
that referenced
this pull request
Oct 3, 2024
* Add a default password reset token to has_secure_password * I hate this * Assist debugging * Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a default configuration for a 15-minute password reset token when using has_secure_password: