Remove deprecated method ActiveRecord::Migrator.proper_table_name #15512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshay-vishnoi this needs a changelog entry. |
|
Hi @senny. I have updated changelog, please check. 😄 |
|
@akshay-vishnoi merged and modified the changelog entry slightly. Thanks 💛 |
senny
added a commit
that referenced
this pull request
Jun 5, 2014
Remove deprecated method ActiveRecord::Migrator.proper_table_name
|
Yeah, you did better actually. Thanks 💚 |
|
How does one go about resolving this deprecation? I've posted the question on SO with example source code. |
|
@scarver2 my guess is that this is caused by a gem. Do you use something, which hooks into migrations? If not, can you upload a minimal sample application that reproduces the issue? You can also post an executable test-case that showcases the deprecation. Use this script as a starting point. |
ShockwaveNN
added a commit
to ONLYOFFICE-QA/testing-wrata
that referenced
this pull request
Jul 8, 2015
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
May 20, 2016
Refer rails/rails#11984 rails/rails#15512 rails/rails@e0f0afb Also removed tests since it is also tested in ActiveRecord itself https://github.com/rails/rails/blob/5-0-stable/activerecord/test/cases/migration_test.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.