fix: resolve news image zoom flickering on hover#526
Merged
Conversation
The hover timeout variable was declared as a local variable inside the component function, causing it to reset on every re-render. When the zoom overlay appeared, it intercepted mouse events, triggering onMouseOut on the thumbnail, which then dismissed the zoom and caused flickering. Changes: - Use useRef for hover timeout to persist across re-renders - Track imageToZoom state with a ref to prevent dismiss when zoom is visible - Add click-to-dismiss on both overlay and zoomed image - Add cursor: pointer for better UX Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The
hoverTimeoutvariable was declared as a local variable inside the component function, causing it to reset toundefinedon every re-render. When the zoom overlay appeared withpointer-events: auto, it intercepted mouse events, triggeringonMouseOuton the thumbnail, which dismissed the zoom - creating a flickering loop.Changes
src/scenes/News/index.tsx:useReffor hover timeout to persist across re-rendersimageToZoomstate with a ref to prevent dismissal when zoom is already visiblesrc/scenes/News/image-zoom.tsx:cursor: pointerfor better UXTest plan
🤖 Generated with Claude Code