Skip to content

FIXES ISSUE #346 enforce case-insensitive uniqueness for column names#454

Merged
emrberk merged 2 commits into
questdb:mainfrom
omsuneri:resolving-#346
Jul 14, 2025
Merged

FIXES ISSUE #346 enforce case-insensitive uniqueness for column names#454
emrberk merged 2 commits into
questdb:mainfrom
omsuneri:resolving-#346

Conversation

@omsuneri
Copy link
Copy Markdown
Contributor

@omsuneri omsuneri commented Jul 14, 2025

column names in the table schema dialog are now validated case-insensitively to prevent duplicate columns like 'Age and 'age' this fixes issue #346 where duplicate column names differing only by case were incorrectly allowed

Demo :

Screen.Recording.2025-07-14.at.12.25.03.PM.mov
@omsuneri
enforce case-insensitive uniqueness for column names
eeedce8 
column names in the table schema dialog are now validated case-insensitively
to prevent duplicate columns like 'Age and 'age' this fixes issue questdb#346
where duplicate column names differing only by case were incorrectly allowed
@omsuneri
Copy link
Copy Markdown
Contributor Author

omsuneri commented Jul 14, 2025

@AayushSaini101 @emrberk the issue is resolved, please review the PR and request if any further changes required !!
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 14, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
emrberk
emrberk reviewed Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@emrberk emrberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good addition would be trimming the values as well, not to end up with columnName and columnName being used.
Otherwise, this one fixes the case-insensitive columns issue.
@omsuneri
trim and lowercase column names for uniqueness validation
f45310f 
prevents issues where columns like ' name ' and 'name' would bypass uniqueness checks when creating new tables via the UI
@omsuneri
Copy link
Copy Markdown
Contributor Author

omsuneri commented Jul 14, 2025

A good addition would be trimming the values as well, not to end up with columnName and columnName being used. Otherwise, this one fixes the case-insensitive columns issue.

@emrberk prevents issues where columns like ' name ' and 'name' would bypass uniqueness checks
due to leading/trailing whitespace. as requested by you

Screen.Recording.2025-07-14.at.10.06.07.PM.mov
emrberk
emrberk approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@emrberk emrberk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.
@emrberk emrberk merged commit 7480cdb into questdb:main Jul 14, 2025
1 check passed
@omsuneri
Copy link
Copy Markdown
Contributor Author

omsuneri commented Jul 14, 2025

@emrberk love to contribute to questdb will be resolving more issues from ahead. 😊
@emrberk emrberk mentioned this pull request Jul 14, 2025
Closed
@emrberk emrberk mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@omsuneri @CLAassistant @emrberk