Skip to content

Conversation

@pfmoore
Copy link
Member

@pfmoore pfmoore commented Aug 9, 2017

  • Rename the new argument to "filterfunc"
  • Improve tests for the new functionality
  • Add a "What's New" entry.

https://bugs.python.org/issue31072

* Rename the new argument to "filterfunc"
* Improve tests for the new functionality
* Add a "What's New" entry.
@pfmoore
Copy link
Member Author

pfmoore commented Aug 9, 2017

@serhiy-storchaka Would you take a look at this and confirm it looks OK to you?

@pfmoore pfmoore merged commit 0780bf7 into python:master Aug 26, 2017
@pfmoore pfmoore deleted the zipapp_fixes branch August 26, 2017 17:04
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
…ython#3049)

bpo-31072: Rename the new filter argument for zipapp.create_archive (pythonGH-3049)

* Rename the new argument to "filter"
* Improve tests for the new functionality
* Add a "What's New" entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants