Skip to content

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Oct 31, 2020

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private function should not be documented. Only public function should be documented.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member

vstinner commented Oct 31, 2020

PR title:

bpo-37483: Add missing API in the What's New in Python 3.9 #23062

I suggest:

bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9

@corona10 corona10 changed the title bpo-37483: Add missing API in the What's New in Python 3.9 bpo-37483: Add PyObject_CallOneArg() in the What's New in Python 3.9 Nov 1, 2020
@corona10
Copy link
Member Author

corona10 commented Nov 1, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 merged commit 7feb54a into python:master Nov 1, 2020
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2020
@bedevere-bot
Copy link

GH-23074 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 1, 2020
@corona10 corona10 deleted the bpo-37483-news branch November 1, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants