Skip to content

[3.13] gh-132578: Rename the threading.Thread._handle field (GH-132696)#132789

Closed
miss-islington wants to merge 1 commit into
python:3.13from
miss-islington:backport-3cfab44-3.13
Closed

[3.13] gh-132578: Rename the threading.Thread._handle field (GH-132696)#132789
miss-islington wants to merge 1 commit into
python:3.13from
miss-islington:backport-3cfab44-3.13

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 21, 2025

Copy link
Copy Markdown
Contributor

Commit 0e9c364f introduced the _handle field on instances of
threading.Thread. Unfortunately it's fairly common for subclasses
of threading.Thread to define a _handle() method, which is shadowed
by the new field.
(cherry picked from commit 3cfab44)

Co-authored-by: mpage mpage@meta.com

…H-132696)

Commit `0e9c364f` introduced the `_handle` field on instances of
`threading.Thread`. Unfortunately it's fairly common for subclasses
of `threading.Thread` to define a `_handle()` method, which is shadowed
by the new field.
(cherry picked from commit 3cfab44)

Co-authored-by: mpage <mpage@meta.com>
@Yhg1s

Yhg1s commented Apr 21, 2025

Copy link
Copy Markdown
Member

Let's hold off on merging this until we've got a clearer picture of the extent of the breakage and the risk of this change. (See #132696 (comment))

@hellypi

hellypi commented May 18, 2025

Copy link
Copy Markdown

Let's hold off on merging this until we've got a clearer picture of the extent of the breakage and the risk of this change. (See #132696 (comment))

You broke every package that was relying on _handle not being a shadowing, so we are past the stage of worrying about breaking previously unbroken libraries. There currently is a way smaller amount of packages that rely on _handle. I would argue for renaming as soon as possible, since newly created packages are more likely to still be maintained compared to older packages.

@pablogsal pablogsal enabled auto-merge (squash) January 25, 2026 17:09
@pablogsal

Copy link
Copy Markdown
Member

Disregard the approve, pressed the button in the wrong PR

@picnixz picnixz disabled auto-merge January 28, 2026 10:03
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 23, 2026
@vstinner

Copy link
Copy Markdown
Member

This backport PR is open for 1 year. IMO it's not too late to merge it. Developers had enough time to update their code to manage the _handle name conflict.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 21, 2026
@kumaraditya303

Copy link
Copy Markdown
Contributor

Agreed, closing it.

@miss-islington miss-islington deleted the backport-3cfab44-3.13 branch July 13, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment