gh-131146: Fix month names in a genitive case in calendar module #131147

plashchynski · 2025-03-12T12:59:05Z

The calendar module displays month names in some locales using the genitive case. This is grammatically incorrect, as the nominative case should be used when the month is named by itself. To address this issue, this change introduces new lists alt_month_name and alt_month_abbr that contain month names in the nominative case. The module now uses %OB format specifier to get month names in the nominative case where available.

Issue: calendar displays month names in a genitive case for some locales #131146

The calendar module displays month names in some locales using the genitive case. This is grammatically incorrect, as the nominative case should be used when the month is named by itself. To address this issue, this change introduces new lists `alt_month_name` and `alt_month_abbr` that contain month names in the nominative case. The module now uses `%OB` format specifier to get month names in the nominative case where available.

ghost · 2025-03-12T12:59:09Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-03-12T12:59:10Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

tomasr8

Thanks for the PR! This will also need a NEWS entry and tests (check Lib/test/test_calendar.py)

Lib/calendar.py

* Limit line length to 79 characters according to PEP8 * Suppress current unit links according to the Documentation Style Guide

Misc/NEWS.d/next/Library/2025-03-17-21-15-04.gh-issue-131146.P9Cdx0.rst

StanFromIreland · 2025-04-09T17:31:35Z

Doc/library/calendar.rst

+   A sequence that represents the months of the year in the current locale.
+   This follows normal convention of January being month number 1, so it has
+   a length of 13 and ``month_name[0]`` is the empty string.


This is just a formatting change and should not be included in this PR.

It's to limit the line length to 80 characters in accordance with the reStructuredText markup guideline

Again, you did not modify this section, please revert it. Existing violations do not have to be fixed, I assure you there are hundreds in the file.

StanFromIreland · 2025-04-09T17:32:19Z

Doc/library/calendar.rst

+   locale. This follows normal convention of January being month number 1, so
+   it has a length of 13 and  ``month_abbr[0]`` is the empty string.


Again unrelated formatting changes

It's to limit the line length to 80 characters in accordance with the reStructuredText markup guideline.

You did not modify this section, it is unrelated to this pr, please revert it.

Lib/calendar.py

StanFromIreland · 2025-04-09T17:35:47Z

Lib/calendar.py

+try:
+    standalone_month_name = _localized_month('%OB')
+    standalone_month_abbr = _localized_month('%Ob')
+except ValueError:
+    # The platform does not support the %OB and %Ob specifiers.
+    standalone_month_name = month_name
+    standalone_month_abbr = month_abbr


Suggested change

try:

standalone_month_name = _localized_month('%OB')

standalone_month_abbr = _localized_month('%Ob')

except ValueError:

# The platform does not support the %OB and %Ob specifiers.

standalone_month_name = month_name

standalone_month_abbr = month_abbr

try:

standalone_month_name = _localized_month('%OB')

standalone_month_abbr = _localized_month('%Ob')

except ValueError:

standalone_month_name = month_name

standalone_month_abbr = month_abbr

The previous comment covers this IMO

StanFromIreland · 2025-04-09T17:38:21Z

Misc/NEWS.d/next/Library/2025-03-17-21-15-04.gh-issue-131146.P9Cdx0.rst

+Add :data:`calendar.standalone_month_name` and :data:`calendar.standalone_month_abbr` to
+provide month names and abbreviations in a grammatical form used when a month name stands
+by itself if the locale provides one.


Both the NEWS entries are for the same issue, they could just be merged. "Fix ... by adding :data:calendar.standalone_month_name and :data:calendar.standalone_month_abbr. These provide ... "

Lib/test/test_calendar.py

bedevere-bot · 2025-04-29T15:44:51Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit 36bb456 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131147%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

encukou · 2025-04-29T15:45:04Z

Thank you for the PR, @plashchynski
~~If you don't beat me to it, I plan to fix the formatting/comments/entries tomorrow so that this gets into 3.14.~~

StanFromIreland · 2025-04-29T16:13:12Z

This also needs a proper test (my comment was incorrectly closed) using support's @run_with_locale, grep the existing tests for usage examples, there are quite a few.

Doc/library/calendar.rst

StanFromIreland · 2025-04-29T16:17:12Z

Doc/library/calendar.rst

+       >>> import calendar
+       >>> list(calendar.standalone_month_name)
+       ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']
+


This example is pointless in the English locale, and it links to month_name with the exact same example.

I agree, it's not relevant for English. But which locale should I use here?

We do not have to provide an example.

StanFromIreland · 2025-04-29T16:17:25Z

Doc/library/calendar.rst

+       >>> import calendar
+       >>> list(calendar.standalone_month_abbr)
+       ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
+


Lib/calendar.py

Doc/library/calendar.rst

StanFromIreland · 2025-04-29T16:25:13Z

Doc/library/calendar.rst

+   A sequence that represents the months of the year in the current locale
+   in the grammatical form used when a month name stands by itself if the locale
+   provides one. If the locale does not supply an alternative form, it is equal to


Suggested change

A sequence that represents the months of the year in the current locale

in the grammatical form used when a month name stands by itself if the locale

provides one. If the locale does not supply an alternative form, it is equal to

A sequence that represents the months of the year in the current locale

in the standalone form if the locale provides one. Else it is equivalent to

Much simpler format, as docs should be e.g.

StanFromIreland · 2025-04-29T16:25:35Z

Doc/library/calendar.rst

+   A sequence that represents the months of the year in the current locale
+   in the grammatical form used when a month name stands by itself if the locale
+   provides one. If the locale does not supply an alternative form, it is equal to


Suggested change

A sequence that represents the months of the year in the current locale

in the grammatical form used when a month name stands by itself if the locale

provides one. If the locale does not supply an alternative form, it is equal to

A sequence that represents the months of the year in the current locale

in the standalone form if the locale provides one. Else it is equivalent to

Much simpler format, as docs should be e.g.

StanFromIreland · 2025-05-08T19:36:42Z

I can finish this off if you are unable to, it should still be backported to 3.14 since it is a bug fix, no?

plashchynski · 2025-05-11T09:37:20Z

This also needs a proper test (my comment was incorrectly closed) using support's @run_with_locale, grep the existing tests for usage examples, there are quite a few.

The problem is specific only to certain locales. To properly test it, we need to have these locales installed. A test with @run_with_locale will fail only on systems where that locales are installed. So for most systems that test will be green without proposed changes. I think it's not worth to add tests that can't fail on most of the systems.

StanFromIreland · 2025-05-11T09:50:29Z

So for most systems that test will be green without proposed changes.

It will not pass, it will be skipped.

I think it's not worth to add tests that can't fail on most of the systems.

It is! Most systems have locale like pl_PL installed anyway, looking at the buildbots the majority do.

plashchynski · 2025-05-11T14:19:14Z

I think it's not worth to add tests that can't fail on most of the systems.

It is! Most systems have locale like pl_PL installed anyway, looking at the buildbots the majority do.

Even if the system has pl_PL installed, it's possible that it doesn't support %OB %Ob extensions. And we don't know for sure weather it supported or not.

Given this, how could we distinguish the wrong behaviour from the fallback route?
I mean, if we test for the standalone form, it's possible that the regular form is returned because of the fallback.
Hope it makes sense.

encukou · 2025-05-19T13:16:25Z

One trick would be to check for some common platform that does support %OB, for example:

if platform.libc_ver()[0] == 'glibc':
    "Polish month 2 MUST be 'luty'"
else:
    "Polish month 2 could be either 'luty' or 'lut'"

serhiy-storchaka · 2025-06-27T12:53:19Z

The test should check for example that calendar.standalone_month_name[5] is contained in the calendar output for May. It can also skip if calendar.standalone_month_name[5] == calendar.month_name[5].

bedevere-app bot added the awaiting review label Mar 12, 2025

bedevere-app bot mentioned this pull request Mar 12, 2025

calendar displays month names in a genitive case for some locales #131146

Open

tomasr8 reviewed Mar 16, 2025

View reviewed changes

Lib/calendar.py Outdated Show resolved Hide resolved

plashchynski added 2 commits March 18, 2025 04:11

Refine news message wording for better clarity

fce8599

Style guide compliance:

7a175d5

* Limit line length to 79 characters according to PEP8 * Suppress current unit links according to the Documentation Style Guide

picnixz reviewed Mar 23, 2025

View reviewed changes

Misc/NEWS.d/next/Library/2025-03-17-21-15-04.gh-issue-131146.P9Cdx0.rst Outdated Show resolved Hide resolved

Fix roles of and in the NEWS.d entry.

36bb456

tomasr8 approved these changes Mar 23, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Mar 23, 2025

hugovk changed the title ~~gh-131146: Fix month names in a genitive case in calendar module.~~ gh-131146: Fix month names in a genitive case in calendar module Mar 24, 2025

StanFromIreland reviewed Apr 9, 2025

View reviewed changes

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2025

StanFromIreland reviewed Apr 29, 2025

View reviewed changes

Doc/library/calendar.rst Outdated Show resolved Hide resolved

StanFromIreland reviewed Apr 29, 2025

View reviewed changes

Lib/calendar.py Outdated Show resolved Hide resolved

StanFromIreland reviewed Apr 29, 2025

View reviewed changes

Doc/library/calendar.rst Outdated Show resolved Hide resolved

StanFromIreland reviewed Apr 29, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

plashchynski added 2 commits May 11, 2025 12:51

Fix grammar and wording

5feb1dc

Rewording

1ecc613

		locale. This follows normal convention of January being month number 1, so
		it has a length of 13 and ``month_abbr[0]`` is the empty string.

Uh oh!

gh-131146: Fix month names in a genitive case in calendar module #131147

Are you sure you want to change the base?

gh-131146: Fix month names in a genitive case in calendar module #131147

Uh oh!

Conversation

plashchynski commented Mar 12, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ghost commented Mar 12, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bedevere-app bot commented Mar 12, 2025

tomasr8 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Apr 29, 2025

encukou commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

StanFromIreland commented Apr 29, 2025

Uh oh!

StanFromIreland Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StanFromIreland commented May 8, 2025

This comment was marked as resolved.

plashchynski commented May 11, 2025

StanFromIreland commented May 11, 2025

plashchynski commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

encukou commented May 19, 2025

serhiy-storchaka commented Jun 27, 2025

plashchynski commented Mar 12, 2025 •

edited by bedevere-app bot

Loading

ghost commented Mar 12, 2025 •

edited by ghost

Loading

encukou commented Apr 29, 2025 •

edited

Loading

StanFromIreland Apr 29, 2025 •

edited

Loading

plashchynski commented May 11, 2025 •

edited

Loading