Skip to content

gh-100321: Remove redundant variable newfree in function analyze_block#100327

Closed
zikcheng wants to merge 1 commit into
python:mainfrom
zikcheng:remove_newfree
Closed

gh-100321: Remove redundant variable newfree in function analyze_block#100327
zikcheng wants to merge 1 commit into
python:mainfrom
zikcheng:remove_newfree

Conversation

@zikcheng

@zikcheng zikcheng commented Dec 18, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
@bedevere-bot bedevere-bot mentioned this pull request Dec 18, 2022
Closed
JosephSBoyle
JosephSBoyle reviewed Dec 18, 2022
View reviewed changes

@JosephSBoyle JosephSBoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
What do the "newfree" and "allfree" vars represent?
@zikcheng

zikcheng commented Dec 18, 2022

Copy link
Copy Markdown
Contributor Author

Hi @JosephSBoyle , in my understanding, allfree represents all free variables in children blocks and newfree is just a copy of allfree.
@JosephSBoyle

JosephSBoyle commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

@zikcheng Thanks for clarifying for me:)
@encukou

encukou commented Apr 10, 2024

Copy link
Copy Markdown
Member

In #101441, the allfree variable was removed instead.

Sorry that we missed this PR!
@encukou encukou closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment