Skip to content

Add --live-server-port option #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2018
Merged

Add --live-server-port option #82

merged 4 commits into from
Aug 28, 2018

Conversation

RazerM
Copy link
Contributor

@RazerM RazerM commented Aug 25, 2018

My use case is that another service has to redirect to the one under test with a statically known port.

@RazerM
Copy link
Contributor Author

RazerM commented Aug 25, 2018

I guess #81 will fix the Travis errors

@nicoddemus
Copy link
Member

I guess #81 will fix the Travis errors

Yep! 👍

We plan to merge lingering PRs and make a new release this weekend.

@RazerM
Copy link
Contributor Author

RazerM commented Aug 26, 2018

I somehow missed #63, but probably because that PR is about two different issues. FWIW, I don't think reading the value from app.config is the right approach.

@nicoddemus
Copy link
Member

@RazerM I merged your branch with the latest master and updated the CHANGELOG.

Thanks again for the PR!

@vitalk
Copy link
Collaborator

vitalk commented Aug 28, 2018

@RazerM, @nicoddemus thanks!

@vitalk vitalk merged commit 61cb484 into pytest-dev:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
close