Skip to content

🐛 fix(seed): validate distribution and version before pip download #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaborbernat merged 2 commits into from
Apr 14, 2026
+98 −0
Merged

🐛 fix(seed): validate distribution and version before pip download #3120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c4449
🐛 fix(seed): validate distribution and version before pip download
gaborbernat Apr 14, 2026
cb460c0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 14, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Apr 14, 2026
commit cb460c0f9a0836d159eaa99392ac849545eb5c83
4 changes: 1 addition & 3 deletions tests/unit/seed/wheels/test_acquire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,7 @@ def test_download_wheel_rejects_bad_distribution(distribution: str, session_app_
"==1.0;echo",
],
)
def test_download_wheel_rejects_bad_version_spec(
version_spec: str, session_app_data, mocker: MockerFixture
) -> None:
def test_download_wheel_rejects_bad_version_spec(version_spec: str, session_app_data, mocker: MockerFixture) -> None:
mocker.patch("virtualenv.seed.wheels.acquire.Popen")
with pytest.raises(ValueError, match="suspicious version spec"):
download_wheel("pip", version_spec, "3.14", [], session_app_data, "folder", os.environ)
Loading