Fix pip seeder with --extra-search-dir specified#1835
Merged
Conversation
gaborbernat
requested changes
May 19, 2020
gaborbernat
left a comment
gaborbernat
left a comment
Contributor
There was a problem hiding this comment.
A more accurate fix, otherwise yeah looks good.
pip needs to have `--find-links` CLI argument for each directory not just once for a list of directories. Fixes: pypa#1834
This tests that the command generated in get_pip_install_cmd() is correct and has --find-links for each folder.
frenzymadness
force-pushed
the
fix_seeder_pip
branch
from
fd41014 to
9f99563
Compare
Contributor
Author
|
Fix updated, test also updated, changelog added. The change to test is basically no-op but it verifies that the command generated in |
Signed-off-by: Bernat Gabor <bgabor8@bloomberg.net>
gaborbernat
force-pushed
the
fix_seeder_pip
branch
from
2588f95 to
2dbdb0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip needs to have
--find-linksCLI argument for each directorynot just once for a list of directories.
Fixes: #1834
tox -e fix_lint)docs/changelogfolderIf you agree with the fix, I'll try to prepare a test for it and a changelog entry.