Skip to content

Make aliases relative symlinks#1610

Merged
gaborbernat merged 1 commit into
pypa:masterfrom
asottile:relative_alias_links
Feb 13, 2020
Merged

Make aliases relative symlinks#1610
gaborbernat merged 1 commit into
pypa:masterfrom
asottile:relative_alias_links

Conversation

@asottile

@asottile asottile commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Resolves #1596

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder
@gaborbernat

gaborbernat commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

If you fix the ci I like where this is going 👍
@asottile

asottile commented Feb 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

If you fix the ci I like where this is going

yep, I goofed on Windows, should be easy when I'm back from meetings :D
@asottile

asottile commented Feb 13, 2020

Copy link
Copy Markdown
Contributor Author

I'm going to split out adding python{}.{} since I don't quite understand why pypy3 is failing
@gaborbernat

gaborbernat commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Sounds good to me 👍
@asottile

asottile commented Feb 13, 2020

Copy link
Copy Markdown
Contributor Author

whew finally green
@gaborbernat gaborbernat merged commit a446286 into pypa:master Feb 13, 2020
@asottile asottile mentioned this pull request Feb 13, 2020
Closed
@asottile asottile deleted the relative_alias_links branch February 13, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@asottile @gaborbernat