Set PHP version to 7.3 for Debian Buster

[ekohl]

No description provided.

[sheenaajay]

Thanks for submitting the PR @ekohl

[lelutin]

oh great! thanks @ekohl for this. I have just hit this limitation when upgrading a debian server with apache.

@sheenaajay do you need any feedback to be able to merge this pull request? e.g. some testing, code review? I'd like to see this merged and released to a new version of the module as soon as possible, so if I can give a hand I'll gladly help

[sheenaajay]

Thanks alot @lelutin . Do you want to take a quick look at the changes. I ran the ad-hoc tests and everything is running clean.

[lelutin]

This first commit looks fine to me

[lelutin]

This list of packages has some differences with the list in the case above (which is being conflated with this elseif case.

fastcgi and suphp are not present in the list here, for ubuntu 18.04, whereas they are present in the list above. it seems as though collapsing these two cases is imposing a change that was not intended?

[lelutin]

er... I apparently don't understand github's interface. I didn't mean to approve this block, but I don't see how to undo this

[ekohl]

This is labelled as needs-tests but I'm not sure what kind of tests you expect for this. Is there anything I can do to move this forward?

[sheenaajay]

@ekohl @lelutin We need to test the module on Debian Buster before adding and releasing.
Our supported operating systems matrix doesn't include Buster yet. Creating an internal ticket to add and test them on Debian Buster platform. Will let you know the progress.

[ekohl]

https://tickets.puppetlabs.com/browse/PA-2402 is the one I'm watching. For my personal infra I don't care because I strongly prefer the distro packages over the AIO builds since it doesn't bundle an entire Ruby but it's useful for other things I have to support.

[lelutin]

@ekohl in my failed attempts at using the github interface, I raised a question (but the interface might somewhat hide it) : there seems to be a change that's happening for ubuntu 18.04. The comment in the section for that version was saying that fastcgi and suphp are not supported anymore, but the merger of the two if cases brings this back for 18.04 -- was this side-effect intentional?

[ekohl]

Ah, you're right. That wasn't intended. Those should be dropped because Debian Stretch also doesn't have -fastcgi and -suphp packages. And the same goes for Cosmic and Disco (which is why I unified them).

[lelutin]

I don't think I can push a new commit on top of @ekohl 's branch for the PR, but here's the missing commit that would remove the two modules that were not supposed to be brought back (was created with git-format-patch, so you can add this on top of the branch with git am 0001-remove-fastcgi-and-suphp-modules-for-debian-stretch-.patch (or any other file name you give it on your computer)

From 68530a935a965da1d467a5fb31506d89a0533fda Mon Sep 17 00:00:00 2001
From: Gabriel Filion <[email protected]>
Date: Mon, 12 Aug 2019 19:59:53 -0400
Subject: [PATCH] remove fastcgi and suphp modules for debian stretch+ and
 ubuntu bionic+

These two packages don't exist anymore in debian and ubuntu. They were
already removed from the previous "case" block for ubuntu bionic+ but
was erroneously brought back by the previous commit.
---
 manifests/params.pp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/manifests/params.pp b/manifests/params.pp
index 657d8390..48466d38 100644
--- a/manifests/params.pp
+++ b/manifests/params.pp
@@ -367,6 +367,7 @@ class apache::params inherits ::apache::version {
         '10'    => '7.3', # Debian Buster
         default => '7.2', # Ubuntu Bionic, Cosmic and Disco
       }
+      # fastcgi and suphp are not packaged anymore in debian or ubuntu
       $mod_packages = {
         'auth_cas'              => 'libapache2-mod-auth-cas',
         'auth_kerb'             => 'libapache2-mod-auth-kerb',
@@ -374,7 +375,6 @@ class apache::params inherits ::apache::version {
         'auth_mellon'           => 'libapache2-mod-auth-mellon',
         'authnz_pam'            => 'libapache2-mod-authnz-pam',
         'dav_svn'               => 'libapache2-mod-svn',
-        'fastcgi'               => 'libapache2-mod-fastcgi',
         'fcgid'                 => 'libapache2-mod-fcgid',
         'geoip'                 => 'libapache2-mod-geoip',
         'intercept_form_submit' => 'libapache2-mod-intercept-form-submit',
@@ -388,7 +388,6 @@ class apache::params inherits ::apache::version {
         'rpaf'                  => 'libapache2-mod-rpaf',
         'security'              => 'libapache2-mod-security2',
         'shib2'                 => 'libapache2-mod-shib2',
-        'suphp'                 => 'libapache2-mod-suphp',
         'wsgi'                  => 'libapache2-mod-wsgi',
         'xsendfile'             => 'libapache2-mod-xsendfile',
       }
-- 
2.20.1

[sheenaajay]

@ekohl @lelutin We have the agents ready and also created a ticket to add the OS to apache module.
Will let you know the testing status. Thank you.

[ekohl]

Rebased and included the changes suggested by @lulutin

[lelutin]

thans @ekohl and @sheenaajay !

[lelutin]

hmm I don't understand how the test failures relate to the change in 81f29b6

[ekohl]

Note sure if it's something I can fix, but The job exceeded the maximum time limit for jobs, and has been terminated. is the current failure on one.

[sheenaajay]

@ekohl Its Travis timeout problem. I have re-kicked the failing job,hopefully it will pass.

[lelutin]

@sheenaajay looks like "Job #4556.4" timed out again :\

[ThoughtCrhyme]

@ekohl You'll need to change the acceptance test as I have here: https://github.com/puppetlabs/puppetlabs-apache/pull/1945/files#diff-3ee224d470a0198372cbb4902460df09R30 or else the acceptance tests will fail.

[ekohl]

Since #1945 was merged and included my fixes this can be closed.