Support building pdk using a dev puppet-runtime build #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pdk required the pdk-runtime component to refer to a valid SHA in the https://github.com/puppetlabs/puppet-runtime repo which makes it difficult to test pdk-runtime changes before committing them. This commit allows the pdk-runtime.json component to refer to an already built dev build that only exists locally such as: { "version":"202311141.4.g81059f6", "location":"file:///home/josh/work/puppet-runtime/output" } Or a pdk-runtime build generated via Vanagon Generic Builder: { "version":"202308240.86.g81059f6", "location":"https://builds.delivery.puppetlabs.net/puppet-runtime/81059f6336c6b8f5f77ab9a3700eb0b2b58d5bcc/artifacts/" } Where the pdk-runtime is relative to the 'location': ${location}/pdk-runtime-${version}.windows-2019-x64.tar.gz
david22swan
approved these changes
Nov 20, 2023
gavindidrichsen
approved these changes
Nov 20, 2023
Contributor
gavindidrichsen
left a comment
gavindidrichsen
left a comment
There was a problem hiding this comment.
Thanks for this new feature Josh!
Member
|
This has worked on a jenkins run so gonna go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pdk required the pdk-runtime component to refer to a valid SHA in the https://github.com/puppetlabs/puppet-runtime repo which makes it difficult to test pdk-runtime changes before committing them.
This commit allows the pdk-runtime.json component to refer to an already built dev build that only exists locally such as:
Or a pdk-runtime build generated via Vanagon Generic Builder:
Where the pdk-runtime is relative to the 'location':
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist