Skip to content

fix: Don't remove comments along with parens#4218

Merged
JelleZijlstra merged 3 commits into
psf:mainfrom
cobaltt7:gh-3815
Feb 12, 2024
Merged

fix: Don't remove comments along with parens#4218
JelleZijlstra merged 3 commits into
psf:mainfrom
cobaltt7:gh-3815

Conversation

@cobaltt7

@cobaltt7 cobaltt7 commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator

Description

Resolves #3815

Checklist - did you ...

  • [y] Add an entry in CHANGES.md if necessary?
  • [y] Add / update tests if necessary?
  • [-] Add new / update outdated documentation?
Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@cobaltt7 cobaltt7 marked this pull request as draft February 8, 2024 17:15
@cobaltt7

cobaltt7 commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator Author

Failing test cases:

value.__dict__[
    key
] = "test"  # set some Thrift field to non-None in the struct aa bb cc dd ee

class A:
    def foo(self):
        for _ in range(10):
            aaaaaaaaaaaaaaaaaaa = bbbbbbbbbbbbbbb.cccccccccc(  # pylint: disable=no-member
                xxxxxxxxxxxx
            )

result = (
    1  # look ma, no comment migration xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
)

string_variable_name = (
    "a string that is waaaaaaaayyyyyyyy too long, even in parens, there's nothing you can do"  # noqa
)
@github-actions

github-actions Bot commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (d87f4f0) to main (dab37a6).


What is this? | Workflow run | diff-shades documentation

Signed-off-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
@cobaltt7 cobaltt7 marked this pull request as ready for review February 9, 2024 16:22

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelleZijlstra JelleZijlstra merged commit 8af4394 into psf:main Feb 12, 2024
@sarvarfx

Copy link
Copy Markdown

plase what is

@cobaltt7 cobaltt7 deleted the gh-3815 branch February 18, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants