Skip to content

Better error message for invalid exclude types#3764

Merged
hauntsaninja merged 5 commits into
psf:mainfrom
hauntsaninja:ext-excl
Jul 5, 2023
Merged

Better error message for invalid exclude types#3764
hauntsaninja merged 5 commits into
psf:mainfrom
hauntsaninja:ext-excl

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

Currently if this is a list, this ends up using the repr of the list as a regex.

Fixes #3574, fixes #3754

Currently if this is a list, this ends up using the repr of the list as
a regex.
@hauntsaninja hauntsaninja marked this pull request as draft July 5, 2023 04:50
@hauntsaninja hauntsaninja marked this pull request as ready for review July 5, 2023 04:53
Comment thread CHANGES.md Outdated
- Fix black not honouring `pyproject.toml` settings when running `--stdin-filename` and
the `pyproject.toml` found isn't in the current working directory (#3719)
- Black will now error if `exclude` and `extend-exclude` have invalid data types in
`pyproject.toml`, instead of silently doing the wrong thing.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`pyproject.toml`, instead of silently doing the wrong thing.
`pyproject.toml`, instead of silently doing the wrong thing. (#3764)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is doing something really weird where the pushes show on the branch in my fork, but don't get reflected in the PR hauntsaninja@9f55e73

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems like there is something weird going on. In any case, this PR looks good once GitHub cooperates.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, the force in force push seems to wake it up. So I just need to commit an empty commit, push it, delete the commit and force push.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great workflow

@hauntsaninja hauntsaninja marked this pull request as draft July 5, 2023 04:53
@github-actions

github-actions Bot commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (9f55e73) to main (8e618f3).%0A%0A---%0A%0AWhat is this? | Workflow run | diff-shades documentation

@hauntsaninja hauntsaninja marked this pull request as ready for review July 5, 2023 05:45
@hauntsaninja hauntsaninja merged commit cf4cc29 into psf:main Jul 5, 2023
@hauntsaninja hauntsaninja deleted the ext-excl branch July 5, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants