Fix black --help output for --python-cell-magics option to be reproducible#3516
Merged
Conversation
Contributor
Author
|
@ichard26 For the changelog, is there an order in which to add the changes? (For example, newest at top per category?) I didn't find a pattern in the unreleased sections: the "Preview style" section seemed to be newest-first, but the "Output" section (the one I think this is concerned), was oldest-first. |
Contributor
Author
|
My CHANGES.md message would be: - Calling `black --help` multiple times will return the same help contents each
time (#3516) |
Collaborator
|
You can put it anywhere in the list, we don't really have a standard. The way we handle merges on this file tends to result in the entries going in somewhat random orders. I might rearrange them on release to put the most significant changes first. |
JelleZijlstra
approved these changes
Jan 22, 2023
Contributor
Author
|
Since I fixed the CI failure for the markdown linting in the CHANGES.md, is everything ready to go now? Am I still missing something? |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3515
This small change is to fix the issue #3515. It adds a
sorted(...)to the PYTHON_CELL_MAGICS set wrapped inside a string.join() in order to have a stable output in theblack --helpcommand. No other changes are required.Checklist - did you ...
CHANGES.mdif necessary? See comment below.