Skip to content

tell users to use -t py310#2668

Merged
JelleZijlstra merged 2 commits into
mainfrom
usetpy310
Dec 4, 2021
Merged

tell users to use -t py310#2668
JelleZijlstra merged 2 commits into
mainfrom
usetpy310

Conversation

@JelleZijlstra

Copy link
Copy Markdown
Collaborator

No description provided.

@isidentical

Copy link
Copy Markdown
Collaborator

This is very cool! Just one question, I know it doesn't sound really good but considering the algorithm is still experimental, would it make sense to run driver.parse_string() on a separate thread with a fixed timeout (idk, .join(timeout=3)?) (in case it gets really really slow, unlikely but still, a nice precaution)?

@ichard26 ichard26 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks!

We could run it under a time restricted thread but that will be a bit more complicated as 3.6 doesn't require systems to have a functional multithreading implementation. Not sure how much it'd be worth.

@JelleZijlstra JelleZijlstra merged commit dc8cdda into main Dec 4, 2021
@JelleZijlstra JelleZijlstra deleted the usetpy310 branch December 4, 2021 23:30
@JelleZijlstra

Copy link
Copy Markdown
Collaborator Author

@isidentical thanks! We discussed on Discord and decided to skip the extra timeout to avoid extra complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants