Merged
Conversation
In Python 3.10 the exception generated by creating a process pool on a Python build that doesn't support this is now `NotImplementedError`
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Collaborator
|
The 3.9 fuzz failure is expected. Thanks for the PR! I'll merge it as soon as the rest of CI passes and I'm on my computer. |
ichard26
approved these changes
Nov 20, 2021
ichard26
left a comment
Collaborator
There was a problem hiding this comment.
I'mma beat you to it Jelle :p
Thank you so much for your contribution! This project is only possible by contributions like these 🖤. You're awesome, @MatthewScholefield. I do wonder how much black is really ran on systems without multiprocessing support like android 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Python 3.10 the exception generated by creating a process pool on a Python build that doesn't support this is now
NotImplementedError.Here is the stack trace I received on Python 3.10 on Termux / Android 11:
Checklist