Use latest Python in uploading binaries#2260
Merged
Merged
Conversation
cooperlees
requested changes
May 26, 2021
cooperlees
left a comment
cooperlees
left a comment
Collaborator
There was a problem hiding this comment.
I feel no pinning at all is needed here. I also feel this minor version pinning won’t do much as there is no idea when a 4.0 will happen …
Let’s see what other maintainers say here.
Collaborator
Author
|
For some reason I prefer Good to go? |
JelleZijlstra
approved these changes
May 27, 2021
ichard26
added
the
C: maintenance
cooperlees
approved these changes
May 27, 2021
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| python-version: "*" |
Collaborator
There was a problem hiding this comment.
I leave this line out in other CI jobs but I guess this is more explicit wildcard …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2252, here to claim my bonus points: I found a way to always use the latest Python minor in GitHub Actions. It seemed easy enough to just drop in, although I'm not really sure how it could be verified without actually uploading.
I do trust the documentation, but if you're a bit scared (like I am too), we could just have the version be set to 3.9 for a guaranteed success. What do ya reckon?
skip news? I'm still not really sure what changes should end up in the changelog but I'm slowly getting there 😅