Skip to content

Exclude venv directory by default#1683

Merged
JelleZijlstra merged 4 commits into
psf:masterfrom
johnthagen:exclude-venv
Apr 10, 2021
Merged

Exclude venv directory by default#1683
JelleZijlstra merged 4 commits into
psf:masterfrom
johnthagen:exclude-venv

Conversation

@johnthagen

@johnthagen johnthagen commented Sep 6, 2020

Copy link
Copy Markdown
Contributor

There hasn't been 100% consensus on what the folder name for a virtual environment should be. Some tools use .venv, others use venv, and there are likely other constructs.

venv is a common name in use.

isort already includes venv in its default list of skipped files.

IMO, this would be a pragmatic addition to black.

@ichard26 ichard26 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a pretty safe change without any apparent downsides. I personally use env as my virtual environment directory name but oh well ¯\_(ツ)_/¯.

Looking forward to your first commit to Black!

@johnthagen

Copy link
Copy Markdown
Contributor Author

@ichard26 / @ambv Conflicts have been resolved and changelog updated.

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once CI is green

@JelleZijlstra JelleZijlstra merged commit e4003c2 into psf:master Apr 10, 2021
@johnthagen johnthagen deleted the exclude-venv branch April 10, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants