Exclude venv directory by default#1683
Merged
Merged
Conversation
ichard26
approved these changes
Oct 17, 2020
ichard26
left a comment
Collaborator
There was a problem hiding this comment.
Seems like a pretty safe change without any apparent downsides. I personally use env as my virtual environment directory name but oh well ¯\_(ツ)_/¯.
Looking forward to your first commit to Black!
Contributor
Author
JelleZijlstra
approved these changes
Apr 10, 2021
JelleZijlstra
left a comment
Collaborator
There was a problem hiding this comment.
I'll merge once CI is green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There hasn't been 100% consensus on what the folder name for a virtual environment should be. Some tools use
.venv, others usevenv, and there are likely other constructs.venvis a common name in use.virtualenvdocs show using the namevenvas the first step in the user guidevenvfolderisortalready includesvenvin its default list of skipped files.IMO, this would be a pragmatic addition to
black.