hpb: Introduce canonical hpb::Arena #21756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_757918262
branch
6 times, most recently
from
07a7097 to
1bb7c41
Compare
copybara-service
bot
force-pushed
the
test_757918262
branch
from
1bb7c41 to
ebc9228
Compare
During our migration, we merely aliased `hpb::Arena` to `upb::Arena` (upb's C++ RAII wrapper for `upb_Arena`). The alias has served us well, but it's now time to transition to a class that'll support our multibackend goals. Henceforth, `hpb::Arena` shall contain an arena based on the SELECTED backend (upb, cpp). If the underlying upb arena needs to be accessed, `arena.ptr()` will no longer work; one must go through `hpb::interop::upb::UnwrapArena`. If the backend is upb, the arena also has support for `.Fuse` and `.IsFused`. PiperOrigin-RevId: 774808755
copybara-service
bot
force-pushed
the
test_757918262
branch
from
ebc9228 to
dd96fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hpb: Introduce canonical hpb::Arena
During our migration, we merely aliased
hpb::Arenatoupb::Arena(upb's C++ RAII wrapper forupb_Arena).The alias has served us well, but it's now time to transition to a class that'll support our multibackend goals. Henceforth,
hpb::Arenashall contain an arena based on the SELECTED backend (upb, cpp).If the underlying upb arena needs to be accessed,
arena.ptr()will no longer work; one must go throughhpb::interop::upb::UnwrapArena.If the backend is upb, the arena also has support for
.Fuseand.IsFused.