Skip to content

Change pre-22 poison pill to only log once per affected message type. #21754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 15, 2025
Merged

Change pre-22 poison pill to only log once per affected message type. #21754

merged 16 commits into from
May 15, 2025

Conversation

esrauchg
Copy link

No description provided.

@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg requested review from shaod2 and zhangskz May 15, 2025 20:22
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg marked this pull request as ready for review May 15, 2025 20:22
@esrauchg esrauchg requested a review from a team as a code owner May 15, 2025 20:22
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
zhangskz
zhangskz reviewed May 15, 2025
View reviewed changes
@esrauchg
Only maintain the set of logged types if we are logging not throwing.
ad63b5b 
Also make the code clearer that we're not logging a stacktrace (exception.toString() doesn't actually have a stack trace in it).
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
zhangskz
zhangskz approved these changes May 15, 2025
View reviewed changes
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 15, 2025
@esrauchg esrauchg merged commit 88a3b90 into protocolbuffers:25.x May 15, 2025
143 of 144 checks passed
noelportillo
noelportillo reviewed Jun 15, 2025
View reviewed changes
Copy link

@noelportillo noelportillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@esrauchg @shaod2 @zhangskz @noelportillo