Patch rules_ruby to apply neverlink = True to the jars rule
#21416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLunn
added
packaging & distribution
jruby
JasonLunn
added a commit
to JasonLunn/rules_ruby-1
that referenced
this pull request
Apr 22, 2025
Prevent the implicit inclusion of JRuby's jars into jars made from .java files that have a compile-time dependency on JRuby. Addresses the root cause of protocolbuffers/protobuf#21369 and will enable the eventual rollback of protocolbuffers/protobuf#21416.
zhangskz
reviewed
Apr 22, 2025
zhangskz
approved these changes
Apr 22, 2025
|
Cherry-pick to 31.x as well once ready? |
p0deje
pushed a commit
to bazel-contrib/rules_ruby
that referenced
this pull request
Apr 23, 2025
Prevent the implicit inclusion of JRuby's jars into jars made from .java files that have a compile-time dependency on JRuby. Addresses the root cause of protocolbuffers/protobuf#21369 and will enable the eventual rollback of protocolbuffers/protobuf#21416.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21369