[Ruby]Implement #to_hash for message classes
#20866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby, `#to_hash` is used for implicit conversion. https://bugs.ruby-lang.org/issues/10180 For example, Active Support uses `#to_hash` when converting an object to JSON. https://github.com/rails/rails/blob/621aa49cefce3313fbc672e2f3681103da686a0e/activesupport/lib/active_support/core_ext/object/json.rb#L60 This PR adds `#to_hash` as the alias of `#to_h`. This allows message objects to convert implicitly to other formats correctly. Fixes protocolbuffers#17037
|
JasonLunn
reviewed
Mar 27, 2025
JasonLunn
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
JasonLunn
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
JasonLunn
approved these changes
Mar 27, 2025
|
It seems that there is a |
JasonLunn
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby,
#to_hashis used for implicit conversion. https://bugs.ruby-lang.org/issues/10180For example, Active Support uses
#to_hashwhen converting an object to JSON. https://github.com/rails/rails/blob/621aa49cefce3313fbc672e2f3681103da686a0e/activesupport/lib/active_support/core_ext/object/json.rb#L60This PR adds
#to_hashas the alias of#to_h. This allows message objects to convert implicitly to other formats correctly.Fixes #17037