fix: contains check segfaults on empty map #20446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
@mjvankampen, would you be able to sign the CLA? We can't proceed with the PR review until you sign it. Thank you. |
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
acozzette
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Thank you for this fix! |
neilconway
pushed a commit
to neilconway/protobuf
that referenced
this pull request
Mar 28, 2025
Fixes protocolbuffers#19624 Closes protocolbuffers#20446 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#20446 from mjvankampen:fix/segfault-empty-map ea87203 PiperOrigin-RevId: 736519479
neilconway
pushed a commit
to neilconway/protobuf
that referenced
this pull request
Mar 28, 2025
Fixes protocolbuffers#19624 Closes protocolbuffers#20446 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#20446 from mjvankampen:fix/segfault-empty-map ea87203 PiperOrigin-RevId: 736519479
This was referenced Mar 28, 2025
anandolee
pushed a commit
that referenced
this pull request
Apr 4, 2025
anandolee
pushed a commit
that referenced
this pull request
Apr 18, 2025
Fixes #19624 COPYBARA_INTEGRATE_REVIEW=#20446 from mjvankampen:fix/segfault-empty-map ea87203 PiperOrigin-RevId: 736519479 Co-authored-by: Mark Jan van Kampen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19624