Ruby: Allow to get a file descriptor by a file name #20287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case.
y-yagi
requested review from
JasonLunn and
ericsalo
and removed request for
a team
JasonLunn
added
ruby
🅰️ safe for tests
|
I'm not sure why, but it seems that |
tonyliaoss
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
Sorry, I'm giving it another kick. The tag was a bit flakey last week but it seemed to still work on other PRs recently. |
JasonLunn
approved these changes
Feb 19, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes #20287 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20287 from y-yagi:lookup_by_filename 760e915 PiperOrigin-RevId: 729187448
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes #20287 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20287 from y-yagi:lookup_by_filename 760e915 PiperOrigin-RevId: 729187448
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes #20287 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20287 from y-yagi:lookup_by_filename 760e915 PiperOrigin-RevId: 729187448
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes #20287 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20287 from y-yagi:lookup_by_filename 760e915 PiperOrigin-RevId: 729187448
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes #20287 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20287 from y-yagi:lookup_by_filename 760e915 PiperOrigin-RevId: 729187448
protobuf-team-bot
added a commit
that referenced
this pull request
Feb 20, 2025
fgarciacorona
pushed a commit
to fgarciacorona/protobuf
that referenced
this pull request
Mar 5, 2025
…20287) In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name. https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46 This feature would be useful to implement such a case. Closes protocolbuffers#20287 PiperOrigin-RevId: 729274388
fgarciacorona
pushed a commit
to fgarciacorona/protobuf
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python, users can get a file descriptor by a file name. https://googleapis.dev/python/protobuf/latest/google/protobuf/descriptor_pool.html#google.protobuf.descriptor_pool.DescriptorPool.FindFileByName
This would be useful for sometimes. For example, GRPC Reflection allows to get a proto by file name.
https://github.com/grpc/grpc-proto/blob/483f11e91a30de9c11d65d872c09bc529e94e2ee/grpc/reflection/v1/reflection.proto#L45-L46
This feature would be useful to implement such a case.