Skip to content

Conversation

@s2x
Copy link
Contributor

@s2x s2x commented Jan 31, 2024

Should fix this #14666

Refactor PHP code for proto3 message handling

This commit enhances the PHP code generation for proto3 messages, specifically focusing on the generated docblock code for the map and repeated. The changes include improved IDE tips to boost development efficiency.

Before:

  • The generated PHP code lacked clear type hints and documentation for map and repeated fields.

After:

  • Added detailed type hints and doc comments for better IDE support.
  • Added test for all map and repeated fields combination.
@s2x s2x requested a review from a team as a code owner January 31, 2024 21:44
@s2x s2x requested review from anandolee and removed request for a team January 31, 2024 21:44
@s2x s2x changed the title Add php generics to map and repeated fields [PHP] Add php generics to map and repeated fields Jan 31, 2024
@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2024
@zhangskz zhangskz requested a review from haberman February 5, 2024 16:41
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Feb 5, 2024
@github-actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label May 22, 2024
@github-actions
Copy link

github-actions bot commented Jun 5, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this Jun 5, 2024
@bshaffer bshaffer reopened this Jun 6, 2024
@bshaffer
Copy link
Contributor

bshaffer commented Jun 6, 2024

This is a duplicate of #11734, I believe

@bshaffer bshaffer self-assigned this Jun 6, 2024
@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jun 7, 2024
@github-actions
Copy link

github-actions bot commented Sep 6, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Sep 6, 2024
@googleberg
Copy link
Member

Closing as duplicate of #11734

@googleberg googleberg closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inactive Denotes the issue/PR has not seen activity in the last 90 days.

4 participants