fix(agent): prevent silent message loss#1122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Agent send flows so user prompts are persisted before preflight/model checks, empty SDK completions become visible errors, and stale queue channels fall back to a fresh run instead of trapping the next message.
The root cause was that several failure paths could complete before a user message or assistant error was written, while completion notifications still treated those turns as successful.
This also suppresses success completion sounds for error or interrupted completions and bumps @proma/electron to 0.14.16.
Validated with
cd apps/electron && bun run typecheck,bun test, andgit diff --check.