Fix flickering header drop shadow#884
Merged
Merged
Conversation
On iOS Safari, headerTop can sometimes be negative when scrolling and the comparison to 0 is no longer true, which removes the drop shadow and causes the flickering. Remove the comparison with the header position to avoid DOM layout reads and fix the flickering by not comparing to exactly 0.
Owner
|
Whee, thanks @holesch! ^.^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS Safari, headerTop can sometimes be negative when scrolling and the comparison to 0 is no longer true, which removes the drop shadow and causes the flickering.
Remove the comparison with the header position to avoid DOM layout reads and fix the flickering by not comparing to exactly 0.
The flickering issue was discussed in #415. This was then linked to #681, but I couldn't reproduce the issue with the "Back to Top" button.