fix(v2v-helper): restore code dropped by PR #2266's mechanical restructure - #2324
Open
spai-p9 wants to merge 1 commit into
Open
fix(v2v-helper): restore code dropped by PR #2266's mechanical restructure#2324spai-p9 wants to merge 1 commit into
spai-p9 wants to merge 1 commit into
Conversation
…cture The migrate.go split in #2266 silently dropped several functions along with their call sites instead of moving them: - openstack/clients.go: 7 PrintLog/DoRetryWithExponentialBackoff calls were left unqualified after pkg/utils was moved behind the pkgutils alias, causing undefined-symbol build failures. - migrate/vm_ops.go: resolveTargetServerID was never moved; its logic got inlined/duplicated into verifyVMCreatedDespiteTimeout instead, breaking the LDM promotion and probe-volume cleanup paths in migrate.go that call resolveTargetServerID directly. - migrate/conversion.go: ldmImageMetadata, mergeBootVolumeImageMetadata, detectLDMGuest, and createLDMProbeVolume were dropped entirely, along with the ConvertVolumes steps that call them - silently disabling LDM (Dynamic Disk) guest handling, not just breaking the build. - migrate/migrate.go: missing "strings" import after the split. Restored the missing functions in the new split files (not the old migrate.go), matching the PR's intended module boundaries, with no logic changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The migrate.go split in #2266 silently dropped several functions along with their call sites instead of moving them:
openstack/clients.go: 7 PrintLog/DoRetryWithExponentialBackoff calls were left unqualified after pkg/utils was moved behind the pkgutils alias, causing undefined-symbol build failures.
migrate/vm_ops.go: resolveTargetServerID was never moved; its logic got inlined/duplicated into verifyVMCreatedDespiteTimeout instead, breaking the LDM promotion and probe-volume cleanup paths in migrate.go that call resolveTargetServerID directly.
migrate/conversion.go: ldmImageMetadata, mergeBootVolumeImageMetadata, detectLDMGuest, and createLDMProbeVolume were dropped entirely, along with the ConvertVolumes steps that call them - silently disabling LDM (Dynamic Disk) guest handling, not just breaking the build.
migrate/migrate.go: missing "strings" import after the split.
Restored the missing functions in the new split files (not the old migrate.go), matching the PR's intended module boundaries, with no logic changes.
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #
Special notes for your reviewer
Testing done
please add testing details (logs, screenshots, etc.)