fix(v2v-helper): drain CopyDisk progress goroutine before closing pipe - #2323
Open
spai-p9 wants to merge 1 commit into
Open
fix(v2v-helper): drain CopyDisk progress goroutine before closing pipe#2323spai-p9 wants to merge 1 commit into
spai-p9 wants to merge 1 commit into
Conversation
CopyDisk closed the progress pipe via defer before its background progress-scanner goroutine had finished draining it, racing the goroutine and occasionally truncating the final read (e.g. the last 100% update). Wait for the goroutine before returning so progress logging always reflects the real completion state (#2139). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
✅ Security Vulnerability SummaryNo change in security posture 📊 Overall Changes
🔍 Detailed Breakdown📦 Gosec (Static Analysis)
📦 Trivy (Dependency Scan)
📋 Baseline Methods
Only HIGH and CRITICAL severity vulnerabilities are tracked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
CopyDisk closed the progress pipe via defer before its background progress-scanner goroutine had finished draining it, racing the goroutine and occasionally truncating the final read (e.g. the last 100% update). Wait for the goroutine before returning so progress logging always reflects the real completion state (#2139).
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #2139
Special notes for your reviewer
Testing done
please add testing details (logs, screenshots, etc.)