Skip to content

[2300] Attachment locking for proxy VMs - #2321

Open
meghansh-pf9 wants to merge 2 commits into
mainfrom
private/main/megh/attach-lock-ha-proxy
Open

[2300] Attachment locking for proxy VMs#2321
meghansh-pf9 wants to merge 2 commits into
mainfrom
private/main/megh/attach-lock-ha-proxy

Conversation

@meghansh-pf9

@meghansh-pf9 meghansh-pf9 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Added a locking mechanism for vJailbreak accelerated copy, to prevent vcenter side errors

Which issue(s) this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)

fixes #2300

Testing Notes

No failing calls during attachment on vcenter

image
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Security Vulnerability Summary

Security posture degraded

📊 Overall Changes

Metric Count
Total Added 2
Total Fixed 0
Net Change +2

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
92 90 2 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

🚨 Added Vulnerabilities

Trivy (Dependencies) - 2 Added

Target: pkg/vpwned/go.mod
Package: golang.org/x/mod v0.29.0
Vulnerability: CVE-2026-56864
Severity: HIGH
Title: A malicious GOSUMDB was capable of serving arbitrary module content no ...

Target: pkg/vpwned/go.mod
Package: golang.org/x/mod v0.29.0
Vulnerability: CVE-2026-56865
Severity: HIGH
Title: A malicious GOPROXY was previously capable of forging up to two sumdb ...


Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: f1081763de23261ca55f1a09823aa923517cc140

@spai-p9 spai-p9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question here, if this happens for attach, will it happen for dettach as well? has that case been covered?

@meghansh-pf9
meghansh-pf9 force-pushed the private/main/megh/attach-lock-ha-proxy branch from 9089ffa to 4a0ed89 Compare August 20, 2026 15:02
@github-actions

Copy link
Copy Markdown
Contributor

✅ Security Vulnerability Summary

No change in security posture

📊 Overall Changes

Metric Count
Total Added 0
Total Fixed 0
Net Change 0

🔍 Detailed Breakdown

📦 Gosec (Static Analysis)

Current Baseline Added Fixed Method
0 0 0 0 artifact

📦 Trivy (Dependency Scan)

Current Baseline Added Fixed Method
92 92 0 0 artifact

📋 Baseline Methods

  • 📦 artifact: Used stored report from main branch
  • 🔄 live_scan: Scanned base branch in real-time
  • ⚠️ no_baseline: No baseline available (all vulnerabilities treated as new)

Only HIGH and CRITICAL severity vulnerabilities are tracked
Baseline: 29134c894d55e8571260619b87ca0ea4b68b84e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants