Various Hardening Updates#617
Merged
Merged
Conversation
Five hardening changes from a security audit. None is a fresh attacker primitive on its own; the audit recommended shipping them as one PR. - `RemoveIniEntry`: anchor the regex with `\b` and `preg_quote` the extension name, so uninstalling `foo` no longer rewrites the prefix of `extension=foo_other` lines. - `PlaceholderReplacer` and `WindowsInstall`: skip symlinks during the recursive source walk, so the iterator no longer descends into files outside the extracted source dir. - `OverrideDownloadUrlInstallListener`: warn that swapping to a release-asset URL leaves only HTTPS-to-origin as the integrity guarantee, since Composer's dist-sha was bound to the original Packagist URL. - `ConfigureOption`: validate `php-ext.configure-options[].name` against `/^[a-zA-Z][a-zA-Z0-9_-]*$/`, so configure-flag identifiers can't carry whitespace or shell metacharacters into argv or `installed.json`. - `FallbackVerificationUsingOpenSsl`: promote the fallback notice to `writeError` and document that the OpenSSL path skips Rekor transparency-log verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five hardening changes from a security audit. None is a fresh attacker primitive on its own; the audit recommended shipping them as one PR.
RemoveIniEntry: anchor the regex with\bandpreg_quotethe extension name, so uninstallingfoono longer rewrites the prefix ofextension=foo_otherlines.PlaceholderReplacerandWindowsInstall: skip symlinks during the recursive source walk, so the iterator no longer descends into files outside the extracted source dir.OverrideDownloadUrlInstallListener: warn that swapping to a release-asset URL leaves only HTTPS-to-origin as the integrity guarantee, since Composer's dist-sha was bound to the original Packagist URL.ConfigureOption: validatephp-ext.configure-options[].nameagainst/^[a-zA-Z][a-zA-Z0-9_-]*$/, so configure-flag identifiers can't carry whitespace or shell metacharacters into argv orinstalled.json.FallbackVerificationUsingOpenSsl: promote the fallback notice towriteErrorand document that the OpenSSL path skips Rekor transparency-log verification.