Skip to content

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 21, 2019

Implementation for union types RFC.

@nikic nikic added the RFC label Oct 21, 2019
Copy link
Contributor

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had time to go through the tests: huge work, nice!

@nikic nikic force-pushed the union-types branch 5 times, most recently from a68c5eb to 471931e Compare October 25, 2019 10:26
Copy link

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks @nikic ❤️

@strongholdmedia
Copy link
Contributor

My only question in retrospect is why wait for PHP 8?
I mean, @nikic stated no backwards-incompatible changes.

@azjezz
Copy link

azjezz commented Jul 8, 2020

@strongholdmedia because 7.4 went feature freez around a year ago 😄 ( https://externals.io/message/106249 )

@strongholdmedia
Copy link
Contributor

Sure, I do know that. :)
I suppose that means there will be no PHP 7.5 then.
Thanks for the implicit heads up. :)

@azjezz
Copy link

azjezz commented Jul 8, 2020

Yes, there's no 7.5 :)

@strongholdmedia
Copy link
Contributor

The uttermost shame is that I am long since subscribed to the internals list, but I couldn't get myself to wade through the nonsense of the attached .eml forest that is a PITA to view :/

Perhaps it is just time to switch to the regular format from the digest stuff.

jrfnl added a commit to PHPCompatibility/PHPCompatibility that referenced this pull request Dec 25, 2022
jrfnl added a commit to PHPCompatibility/PHPCompatibility that referenced this pull request Dec 25, 2022
jrfnl added a commit to PHPCompatibility/PHPCompatibility that referenced this pull request Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants