Skip to content

iconv fix for illumos distributions #18933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

iconv fix for illumos distributions #18933

wants to merge 1 commit into from
+1 −1

Conversation

jMichaelA
Copy link

Extends the ICONV_CONST const preprocessor for iconv to illumos based distributions.
@Girgias Girgias requested a review from devnexen June 25, 2025 10:28
@devnexen
Copy link
Member

Yes I looked at it last night, was (pleasantly) surprised that __illumos__ exists ! Will relook a bit later today. Cheers.
@jMichaelA
Copy link
Author

Thanks devnexen. I made this for OmniOS, and I ran through a basic installation. Let me know if you have any questions that I can help with!
@devnexen
Copy link
Member

The only question I would have .. should solaris have the same treatment ? solaris is still supported until 2027 I believe.
@jMichaelA
Copy link
Author

jMichaelA commented Jun 25, 2025 •
edited
Loading

defined(__sun) && defined(__SVR4) works for OmniOS and should work to support more Solaris distros as well. So that would be a good option as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension: iconv
2 participants
@jMichaelA @devnexen