fix: disable timeout on DbTool level#8357
Merged
Merged
Conversation
Contributor
Author
|
one issue i had while getting started was that in |
wlawt
force-pushed
the
issue-7707-dbtool
branch
2 times, most recently
from
9e3803b to
457c57b
Compare
mattsse
approved these changes
May 23, 2024
mattsse
left a comment
mattsse
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, pending @shekhirin
DaniPopes
approved these changes
May 23, 2024
Contributor
Author
|
not sure, but these lint issues don't look related to this PR? or is there a way for me to address these @mattsse @DaniPopes @shekhirin . thank u! |
Contributor
|
this is fixed on main, just rebase |
Contributor
Author
|
done @DaniPopes , thank u! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7707 .
Overview
This PR disables timeout on the DbTool level, as it's only used by the CLI.
Test Plan