Skip to content

BUG: Fix lost precision with common type of uint64/int64 #61679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbrochart wants to merge 13 commits into from
Closed

BUG: Fix lost precision with common type of uint64/int64 #61679

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
02126dd
BUG: Fix implicit conversion to float64 with isin()
pbrochart Jun 19, 2025
73ad0dc
fix pre-commit
pbrochart Jun 19, 2025
e0afe0b
fix type
pbrochart Jun 19, 2025
802ac84
fix typo
pbrochart Jun 19, 2025
670a8f9
remove import of numpy and pandas
pbrochart Jun 19, 2025
eaba844
import code into isin() and remove function
pbrochart Jun 25, 2025
924f665
fix pre-commit
pbrochart Jun 25, 2025
10debda
fix type
pbrochart Jun 25, 2025
c8f854c
remove unused type
pbrochart Jun 25, 2025
fb52fb6
better patch
pbrochart Jun 28, 2025
a2f2bff
another better patch
pbrochart Jul 1, 2025
d996cf6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 1, 2025
4586cb2
Merge branch 'main' into main
pbrochart Jul 19, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove import of numpy and pandas
  • Loading branch information
@pbrochart
pbrochart committed Jun 19, 2025
commit 670a8f9f38b9b0f316e74cff9a6e16bfe95577bd
2 changes: 0 additions & 2 deletions pandas/core/dtypes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,6 @@ def is_implicit_conversion_to_float64(source, target) -> bool:
False
>>> is_implicit_conversion_to_float64("int", int)
False
>>> import numpy as np
>>> is_implicit_conversion_to_float64(int, np.int64)
False
>>> is_implicit_conversion_to_float64(np.uint64, np.int64)
Expand All @@ -762,7 +761,6 @@ def is_implicit_conversion_to_float64(source, target) -> bool:
False
>>> is_implicit_conversion_to_float64(object, "category")
False
import pandas as pd
>>> is_implicit_conversion_to_float64(np.int64, pd.UInt64Dtype())
True
>>> from pandas.core.dtypes.dtypes import CategoricalDtype
Expand Down
Loading