-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
Implemented NumbaExecutionEngine #61487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthurlw
wants to merge
36
commits into
pandas-dev:main
Choose a base branch
from
arthurlw:numba_execution_engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
aa42037
Implemented NumbaExecutionEngine
arthurlw db9f3b0
whatsnew
arthurlw 4cb240d
precommit
arthurlw 97d9063
Match function arguments
arthurlw 69e0e35
Fix CI
arthurlw 7365079
updated whatsnew
arthurlw c605857
Updated conditions and delegate method to numba.jit
arthurlw 24a0615
Added try and except to catch ImportError
arthurlw b7a2ecb
Use import_optional_dependency to load Numba
arthurlw 545db65
Merge branch 'main' into numba_execution_engine
arthurlw 6f4fb50
Updated engine handling: normalizing numba to a fake decorator and up…
arthurlw 221cf7c
Added check for empty engine_kwargs
arthurlw ed8dc7f
Moved checks from Apply.apply to NumbaExecutionEngine.apply
arthurlw 65b9d32
Fixed CI, removed unused numba checks, updated raw=false condition, u…
arthurlw 2703f86
Implement and refactor raw=False logic into NumbaExecutionEngine.apply
arthurlw 347463e
Fix CI, update validate_values_for_numba params
arthurlw 77eb146
Adjust error messages
arthurlw 90f264f
Remove Numba-specific logic from FrameApply, added Series import to v…
arthurlw f8f1166
pre-commit
arthurlw bc2939b
Updated with reviewer suggestions and added axis normalizing
arthurlw 176753b
Updated executor to accept decorator
arthurlw cf3e392
Fix CI and pre-commit
arthurlw a4bac18
Silence pyright warning for untyped decorator
arthurlw ca91e89
Revert elif to if
arthurlw e337cb8
Fix engine_kwargs handling in validate_values_for_numba_raw_false
arthurlw 30703b9
Fix CI and removed references to engine and enginekwargs in FrameApply
arthurlw b39a8d1
Added test for axis with string input
arthurlw 2b59eeb
pre-commit
arthurlw f59fb52
Revert test for numba apply with string axis due to docstring validat…
arthurlw 984a008
Merge branch 'main' into numba_execution_engine
datapythonista b08c361
Updated engine_kwargs extraction logic and added test
arthurlw 8943e0a
Merge
arthurlw f330473
Fix CI and pre-commit
arthurlw c05b1a7
Add return type annotation for extract_numba_options
arthurlw 4b650d0
Updated with reviewer suggestions
arthurlw 85e3dd3
Merge branch 'main' into numba_execution_engine
arthurlw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix CI and pre-commit
- Loading branch information
commit cf3e39288ca90c17c5c5875936c536fa5ce2b2ff
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good to make the second argument a keyword argument, it's not clear from this call what the method is expecting.
And I'm not sure when
decoratorcan be a dictionary? Afaikdecoratoris the engine, I don't understand the logic here. Is it possible that this always pass an empty dictionary? Feels like if you want to check if numba.jit has been initialized withparallel=Trueor others you should check an attribute of it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out, I overlooked it earlier. Will update in the next commit