Skip to content

Conversation

@cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 14, 2013

closes #3907.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 14, 2013

@jreback merge-able? i can remove _is_sequence in a later pr if u want but that is low priority...

@cpcloud
Copy link
Member Author

cpcloud commented Jun 14, 2013

u know what let me add some tests for the things i added to common.py

@jreback
Copy link
Contributor

jreback commented Jun 14, 2013

did Travis check this?

@cpcloud
Copy link
Member Author

cpcloud commented Jun 14, 2013

it did but i just pushed another commit so rerunning :|

@cpcloud
Copy link
Member Author

cpcloud commented Jun 14, 2013

(passed the first time)

@cpcloud
Copy link
Member Author

cpcloud commented Jun 14, 2013

ok now it's ready

@jreback
Copy link
Contributor

jreback commented Jun 15, 2013

ok just recall if I changed something really low level sometimes things break

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

oh. what did u change that is low-level?

@jreback
Copy link
Contributor

jreback commented Jun 15, 2013

no was a while ago

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

ah len is there for StringMethods. putting it back...

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

and i will write a test so that someone doesn't take it out in the future

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

although a test still passes because of my addition of __iter__ to StringMethods a while back. i'm just going to add the test and keep len out of is_list_like

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

oh i also need 2 change the replace docs i think...

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

nope nothing about infer_types in there

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

ok build is passing.

@cpcloud
Copy link
Member Author

cpcloud commented Jun 15, 2013

@jreback merge-able round 2?

@jreback
Copy link
Contributor

jreback commented Jun 15, 2013

looks good
very minor point - can u put next to where (or even include) as part of your other replace changes in release notes - then they r all together

@ghost ghost assigned cpcloud Jun 15, 2013
@jreback jreback merged commit 7b59332 into pandas-dev:master Jun 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants