feat(ast)!: narrow TSInterfaceHeritage::expression to TSTypeName

[camc314]

Summary

Narrow TSInterfaceHeritage from a general JavaScript Expression to TSTypeName.

pub struct TSInterfaceHeritage<'a> {
    pub type_name: TSTypeName<'a>,
    pub type_arguments: Option<Box<'a, TSTypeParameterInstantiation<'a>>>,
}

Breaking Change

The Rust AST field changes from:

expression: Expression<'a>

to:

type_name: TSTypeName<'a>

Why?

The current AST can represent shapes such as:

interface A extends foo() {}
interface A extends A + B {}
interface A extends new Foo() {}
interface A extends true {}

Which is an overly wide type since all of the above variants are invalid.

This PR tightens up the AST, making these invalid variants irrepresentable.

How to migrate?

This should be a trivial migration:

1. instead of accessing expression on TSInterfaceHeritage, now access type_name
2. change any pattern matching on the type_name field to use TypeName (this is a smaller subset so should allow deleting code!)

closes #25687

[codspeed-hq]

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 14 skipped benchmarks¹

---

_{Comparing codex/narrow-ts-interface-heritage (0bff1a8) with main (6529d1a)}

Footnotes

1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[oxc-guard]

Monitor Oxc

Commit: 4f3c0c310adc

suite	result
Test262	❌
Build	✅
Runtime Bundles	✅
Uglify Corpus	✅
(compressor)	✅
(formatter_dcr)	✅
Isolated Declarations	❌
(transformer)	✅
(codegen)	✅
(formatter)	❌
(mangler)	❌
(whitespace)	✅
(dce)	✅
Runtime (es-toolkit)	✅
Runtime (vue)	✅
Runtime (svelte)	✅
Runtime (zod)	✅
Runtime (solid)	✅

[oxc-guard]

Oxlint Ecosystem CI

suite	result
microsoft/vscode	❌
rolldown/rolldown	❌
vercel/next.js	❌
toeverything/affine	❌
bbc/simorgh	❌
cloudflare/kumo	❌
napi-rs/napi-rs	❌
oven-sh/bun	❌
nestjs/nest	❌
Milkdown/milkdown	❌
monkeytypegame/monkeytype	❌
sidebase/nuxt-auth	❌
outline/outline	❌
bluesky-social/social-app	✅
preactjs/preact	❌
calcom/cal.com	❌
cloudflare/agents	❌
oxidecomputer/console	❌
PostHog/posthog	❌
cloudflare/workers-sdk	❌
renovatebot/renovate	❌
glide-browser/glide	❌
vercel/turborepo	❌
elastic/kibana	✅
matter-js/matter.js	❌
formatjs/formatjs	✅
npmx-dev/npmx.dev	❌
date-fns/date-fns	❌
actualbudget/actual	❌
DefinitelyTyped/DefinitelyTyped	❌

[oxc-guard]

Oxfmt Ecosystem CI

suite	oxfmt@latest	main	refs/pull/24360/head branch
monkeytypegame/monkeytype	❌	🟨	✅
vuejs/pinia	❌	🟨	✅
fastify/fastify-vite	❌	✅	✅
cloudflare/agents	❌	🟨	✅
cloudflare/workers-sdk	❌	🟨	✅
rolldown/rolldown	✅	✅	✅
vercel/turborepo	✅	✅	✅
mastodon/mastodon	❌	🟨	✅
lichess-org/lila	❌	✅	✅
formatjs/formatjs	❌	✅	✅
AmanVarshney01/create-better-t-stack	✅	✅	✅
huggingface/huggingface.js	❌	✅	✅
eggjs/egg	❌	✅	✅
openclaw/openclaw	❌	✅	✅
dyad-sh/dyad	❌	🟨	✅
cnpm/cnpmcore	❌	✅	✅
fuma-nama/fumadocs	✅	✅	✅
aidenybai/react-grab	❌	✅	✅
mantinedev/mantine	✅	✅	✅
actualbudget/actual	❌	🟨	✅
getsentry/sentry-javascript	❌	✅	✅
Comfy-Org/ComfyUI_frontend	❌	✅	✅
npmx-dev/npmx.dev	❌	✅	✅
vuejs/core	✅	🟨	✅
cloudflare/kumo	✅	🟨	✅
tale/headplane	❌	✅	✅

💥 = panic, ⚠️ = error e.g. parse error (main/branch columns: only new errors), ❌ = diff or exit code mismatch, 🟨 = differs from oxfmt@latest (merged-but-unreleased changes)

[camc314]

/monitor-oxc run

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f3c0c310a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[Copilot]

Pull request overview

This PR tightens the Rust AST representation of TypeScript interface heritage clauses by replacing TSInterfaceHeritage::expression: Expression<'a> with TSInterfaceHeritage::type_name: TSTypeName<'a>, making several invalid extends forms structurally unrepresentable in the AST and aligning parsing/serialization behavior accordingly.

Changes:

• Narrow TSInterfaceHeritage from Expression to TSTypeName and update traversal/visitor/codegen/formatter/semantic/linter integrations to use type_name.
• Improve parser diagnostics for invalid/empty extends clauses (e.g. TS1097 empty list, TS1009 trailing comma, TS2499 invalid heritage target) and add a new negative fixture.
• Update JS/NAPI raw-transfer deserializers and walkers to read the new layout and keep TS-ESTree compatibility by converting TSQualifiedName into MemberExpression for the expression field.

Reviewed changes

Copilot reviewed 14 out of 43 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tasks/coverage/snapshots/parser_typescript.snap	Updates TypeScript conformance snapshot output for new interface-heritage diagnostics.
tasks/coverage/snapshots/parser_misc.snap	Updates misc snapshot counts and adds new expected failures for invalid interface heritage.
tasks/coverage/snapshots/parser_babel.snap	Updates Babel snapshot expectations to reflect new diagnostics and recovery.
tasks/coverage/misc/fail/ts-interface-invalid-heritage.ts	Adds a new negative fixture covering invalid interface heritage forms.
napi/parser/src-js/generated/lazy/walk.js	Lazy walker updated to traverse TSTypeName at the heritage field offset.
napi/parser/src-js/generated/lazy/constructors.js	Lazy constructors updated to construct TSTypeName for TSInterfaceHeritage.expression.
napi/parser/src-js/generated/deserialize/ts.js	TS deserializer updated to read TSTypeName and convert qualified names to MemberExpression for TS-ESTree expression.
napi/parser/src-js/generated/deserialize/ts_range.js	Same as above, with range support.
napi/parser/src-js/generated/deserialize/ts_range_parent.js	Same as above, with range + parent support.
napi/parser/src-js/generated/deserialize/ts_parent.js	Same as above, with parent support.
napi/parser/src-js/generated/deserialize/js.js	JS deserializer updated analogously for the new heritage layout.
napi/parser/src-js/generated/deserialize/js_range.js	Same as above, with range support.
napi/parser/src-js/generated/deserialize/js_range_parent.js	Same as above, with range + parent support.
napi/parser/src-js/generated/deserialize/js_parent.js	Same as above, with parent support.
apps/oxlint/src-js/generated/deserialize.js	Oxlint JS deserializer updated to match the new heritage layout and TS-ESTree conversion.
crates/oxc_traverse/src/generated/walk.rs	Traverse walker updated to walk TSTypeName instead of Expression in interface heritage.
crates/oxc_traverse/src/generated/scopes_collector.rs	Removes visiting the old expression field for TSInterfaceHeritage.
crates/oxc_traverse/src/generated/ancestor.rs	Updates ancestor types/offsets/accessors for TSInterfaceHeritage.type_name.
crates/oxc_semantic/src/builder.rs	Semantic builder updated to visit type_name as a type reference.
crates/oxc_parser/src/ts/statement.rs	Parser updated to parse/validate interface heritage as a TSTypeName and emit TS-aligned diagnostics.
crates/oxc_parser/src/js/class.rs	Refactors class heritage parsing wrapper and improves duplicate-extends handling.
crates/oxc_parser/src/diagnostics.rs	Adds TS1097 empty-extends and TS1009 trailing-comma diagnostics helpers.
crates/oxc_minifier/src/traverse_context/scopes_collector.rs	Removes visiting the old expression field for TSInterfaceHeritage.
crates/oxc_minifier/src/generated/walk.rs	Minifier traverse walker updated to walk TSTypeName in interface heritage.
crates/oxc_minifier/src/generated/ancestor.rs	Minifier ancestor types/offsets/accessors updated for TSInterfaceHeritage.type_name.
crates/oxc_linter/src/snapshots/typescript_no_empty_interface.snap	Snapshot updated to reflect TS1097 diagnostic for empty extends list.
crates/oxc_linter/src/rules/typescript/prefer_function_type.rs	Lint rule updated to match on TSInterfaceHeritage.type_name.
crates/oxc_linter/src/rules/typescript/no_wrapper_object_types.rs	Lint rule updated to match on TSInterfaceHeritage.type_name.
crates/oxc_linter/src/rules/typescript/no_unsafe_function_type.rs	Lint rule updated to match on TSInterfaceHeritage.type_name.
crates/oxc_linter/src/rules/typescript/no_invalid_void_type.rs	Updates span extraction to use type_name.span().
crates/oxc_formatter/src/print/mod.rs	Formatter updated to print type_name for interface heritage and adjust grouping heuristic.
crates/oxc_formatter/src/ast_nodes/generated/ast_nodes.rs	Formatter AST node accessor renamed from expression() to type_name().
crates/oxc_codegen/src/gen.rs	Codegen updated to print the TSTypeName for interface heritage.
crates/oxc_ast/src/serialize/ts.rs	Adds TSInterfaceHeritageExpression adapter to serialize type_name as TS-ESTree expression (MemberExpression conversion).
crates/oxc_ast/src/generated/derive_estree.rs	Uses the new adapter when serializing TSInterfaceHeritage.expression.
crates/oxc_ast/src/generated/derive_dummy.rs	Dummy impl updated to fill type_name instead of expression.
crates/oxc_ast/src/generated/derive_content_eq.rs	Content equality updated to compare type_name.
crates/oxc_ast/src/generated/derive_clone_in.rs	CloneIn updated to clone type_name.
crates/oxc_ast/src/generated/ast_builder.rs	AST builder updated to accept type_name: TSTypeName.
crates/oxc_ast/src/generated/assert_layouts.rs	Layout assertions updated for type_name field offsets.
crates/oxc_ast/src/ast/ts.rs	Changes the Rust AST field to type_name and wires TS-ESTree rename/via adapter.
crates/oxc_ast_visit/src/generated/visit.rs	Visitor generation updated to visit type_name as a TS type name.
crates/oxc_ast_visit/src/generated/visit_mut.rs	Mutable visitor generation updated to visit type_name as a TS type name.

[camc314]

Merge activity

• Aug 6, 2:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 6, 3:06 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 6, 3:13 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test wasm32-wasip1-threads', 'Semgrep').
• Aug 6, 3:36 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 6, 3:40 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 6, 3:42 PM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (A required status check is failing on this PR. Please address the failing check and retry the merge.).
• Aug 6, 4:07 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Aug 7, 6:00 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Aug 7, 6:05 AM UTC: Merged by the Graphite merge queue.