https-dns-proxy: update to 2026.03.18-4#29469
Open
stangri wants to merge 1 commit into
Open
Conversation
Maintainer: me Compile tested: x86_64, Dell EMC Edge620, OpenWrt 25.12.1 Run tested: x86_64, Dell EMC Edge620, OpenWrt 25.12.1 Description: Robustify nftables notrack generation - Bump PKG_RELEASE to 4. - Add install rule to create /usr/share/nftables.d/ruleset-post. files/etc/init.d/https-dns-proxy: - Check if 'nft' command exists before generating rules. - Add robust error handling for directory creation and file writing. - Log errors when directory creation or file writing fails. tests/run_tests.sh: - Add test case for 'nft' binary absence, confirming no-op behavior. - Add test case for mkdir failure during notrack rule generation. Signed-off-by: Stan Grishin <stangri@melmac.ca>
stangri
commented
May 16, 2026
| $(INSTALL_CONF) ./files/etc/config/https-dns-proxy $(1)/etc/config/https-dns-proxy | ||
| $(INSTALL_DIR) $(1)/etc/uci-defaults/ | ||
| $(INSTALL_BIN) ./files/etc/uci-defaults/50-https-dns-proxy-migrate-options.sh $(1)/etc/uci-defaults/50-https-dns-proxy-migrate-options.sh | ||
| $(INSTALL_DIR) $(1)/usr/share/nftables.d/ruleset-post |
Member
Author
Member
There was a problem hiding this comment.
What I think is happening here (I haven't gone through all your changes yet) is that the folder is empty, which is why it gets removed and is still missing. There should be at least something in there. :) What most people do in this case is create an empty file to prevent the empty folder from being removed. For example, search for touch (like it's done in syslog-ng, netdata, etc.).
Member
Author
There was a problem hiding this comment.
@BKPepe thanks for your prompt reply, so your recommendation before resorting to having a folder in the Makefile, I should try touching a file in there immediately after mkdir -p?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: x86_64, Dell EMC Edge620, OpenWrt 25.12.1
Run tested: x86_64, Dell EMC Edge620, OpenWrt 25.12.1
Description:
Robustify nftables notrack generation
Makefile:
files/etc/init.d/https-dns-proxy:
tests/run_tests.sh: