Skip to content

ComputedConstantList: replace CAS+volatile get with CAE#3

Merged
minborg merged 1 commit into
openjdk:computed-constantsfrom
liachmodded:cc/cae
Dec 11, 2023
Merged

ComputedConstantList: replace CAS+volatile get with CAE#3
minborg merged 1 commit into
openjdk:computed-constantsfrom
liachmodded:cc/cae

Conversation

@liach

@liach liach commented Sep 20, 2023

Copy link
Copy Markdown
Member
  1. MH's Errors like OutOfMemoryError should be propagated
  2. List CC can use CAE instead of CAS+getVolatile

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/leyden.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/3.diff

1. MH's Errors like OutOfMemoryError should be propagated
2. List CC can use CAE instead of CAS+getVolatile
@bridgekeeper

bridgekeeper Bot commented Sep 20, 2023

Copy link
Copy Markdown

👋 Welcome back liach! A progress list of the required criteria for merging this PR into computed-constants will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bridgekeeper

bridgekeeper Bot commented Dec 4, 2023

Copy link
Copy Markdown

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@minborg

minborg commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

Thank you for these improvements!

@minborg minborg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@minborg

minborg commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

I am a bit unsure about the procedures here. I could just "Squash and merge" or should @liach "/integrate" after creating an issue?

@liach

liach commented Dec 8, 2023

Copy link
Copy Markdown
Member Author

Does Project Leyden require issues for patch submission? This pull request does not have a JBS issue since #1 didn't.

@minborg minborg merged commit 3b5acc5 into openjdk:computed-constants Dec 11, 2023
openjdk Bot pushed a commit that referenced this pull request Sep 24, 2024
Reviewed-by: honkar, prr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants