feat: add fromReadableStream to ResponseStream#1987
Merged
HAYDEN-OAI merged 3 commits intoJul 13, 2026
Conversation
Contributor
|
pushed a follow-up fix for cancellation. Stream.fromReadableStream now holds the source reader and cancels it when the runner aborts, so ResponseStream.fromReadableStream will not hang on a stalled proxy body. i also added a regression test that verifies the source stream is canceled and done() rejects with APIUserAbortError. |
HAYDEN-OAI
approved these changes
Jul 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
ResponseStreamdoes not have the same readable-stream rehydration helper thatChatCompletionStreamandAssistantStreamexpose, so callers proxying newline-delimited response stream events cannot turn them back into aResponseStream. This addsResponseStream.fromReadableStream()and a protected_fromReadableStream()path that readsResponseStreamEventvalues throughStream.fromReadableStream()and feeds them through the existing response-stream event handling. Generated response resources stay unchanged.Additional context & links
Fixes #1376