Add acknowledged user message submission to core - #36385
Merged
copyberry[bot] merged 1 commit intoJul 31, 2026
Merged
Conversation
## What changed - Add `CodexThread::submit_user_input_and_wait_for_admission` and export the `UserMessageAdmission` result through `codex-core-api`. - Resolve submissions only after they start a new turn or steer the active turn, returning the accepting turn ID in either case. - Return errors for invalid operations, rejected thread settings, and session termination instead of leaving admission waiters unresolved. ## Testing Add integration coverage for concurrent start-and-steer submissions, settings rejection and recovery, non-user operations, and submission after shutdown. GitOrigin-RevId: 21f1ede38d399baa9836d61a59b9f9af2dbf83b8
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8
branch
from
July 31, 2026 20:18
7db0346 to
bf7804c
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8
branch
July 31, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add acknowledged user message submission to core
What changed
CodexThread::submit_user_input_and_wait_for_admissionand export theUserMessageAdmissionresult throughcodex-core-api.turn, returning the accepting turn ID in either case.
termination instead of leaving admission waiters unresolved.
Testing
Add integration coverage for concurrent start-and-steer submissions, settings
rejection and recovery, non-user operations, and submission after shutdown.