Skip to content

Add acknowledged user message submission to core - #36385

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8
Jul 31, 2026
Merged

Add acknowledged user message submission to core#36385
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 31, 2026

Copy link
Copy Markdown

Add acknowledged user message submission to core

What changed

  • Add CodexThread::submit_user_input_and_wait_for_admission and export the
    UserMessageAdmission result through codex-core-api.
  • Resolve submissions only after they start a new turn or steer the active
    turn, returning the accepting turn ID in either case.
  • Return errors for invalid operations, rejected thread settings, and session
    termination instead of leaving admission waiters unresolved.

Testing

Add integration coverage for concurrent start-and-steer submissions, settings
rejection and recovery, non-user operations, and submission after shutdown.

## What changed

- Add `CodexThread::submit_user_input_and_wait_for_admission` and export the
  `UserMessageAdmission` result through `codex-core-api`.
- Resolve submissions only after they start a new turn or steer the active
  turn, returning the accepting turn ID in either case.
- Return errors for invalid operations, rejected thread settings, and session
  termination instead of leaving admission waiters unresolved.

## Testing

Add integration coverage for concurrent start-and-steer submissions, settings
rejection and recovery, non-user operations, and submission after shutdown.

GitOrigin-RevId: 21f1ede38d399baa9836d61a59b9f9af2dbf83b8
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8 branch from 7db0346 to bf7804c Compare July 31, 2026 20:18
@copyberry
copyberry Bot merged commit bf7804c into main Jul 31, 2026
28 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/21f1ede38d399baa9836d61a59b9f9af2dbf83b8 branch July 31, 2026 20:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants