Avoid overwriting symlinked migration targets - #36051
Merged
copyberry[bot] merged 1 commit intoJul 30, 2026
Merged
Conversation
## Why External-agent migration treated symlinked empty text targets as overwritable files. Writing migrated configuration through such a target could modify a file outside the repository. ## What changed - Use symlink metadata when checking whether a migration target is missing or empty, so only regular files are considered overwritable. - Preserve symlinked `AGENTS.md` and `.codex/hooks.json` targets during both detection and import. ## Testing Added Unix regression coverage for existing and dangling symlink targets for both guidance and hooks migration. See #26021. GitOrigin-RevId: 13c78e7458d1c02abdb22b38ba88ed66bb5a154b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/13c78e7458d1c02abdb22b38ba88ed66bb5a154b
branch
from
July 30, 2026 00:50
7cba831 to
b1ccaa0
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/13c78e7458d1c02abdb22b38ba88ed66bb5a154b
branch
July 30, 2026 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid overwriting symlinked migration targets
Why
External-agent migration treated symlinked empty text targets as overwritable files. Writing migrated configuration through such a target could modify a file outside the repository.
What changed
AGENTS.mdand.codex/hooks.jsontargets during both detection and import.Testing
Added Unix regression coverage for existing and dangling symlink targets for both guidance and hooks migration.
See #26021.