Use the shared HTTP client for announcement tips - #35825
Merged
copyberry[bot] merged 1 commit intoJul 28, 2026
Merged
Conversation
## Why Announcement prewarming disabled proxy discovery to avoid the macOS sandbox panic fixed by #16670. ## What changed - Fetch announcement tips asynchronously with `RouteAwareClientPool` instead of a blocking `reqwest` client. - Pass the configured `HttpClientFactory` into prewarming so announcement requests honor the configured outbound proxy policy. GitOrigin-RevId: 535158d95a99c6f515bd30ea6e3bcb2ac6bb6d7e
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/535158d95a99c6f515bd30ea6e3bcb2ac6bb6d7e
branch
from
July 28, 2026 20:12
eb742a7 to
155c3e2
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/535158d95a99c6f515bd30ea6e3bcb2ac6bb6d7e
branch
July 28, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the shared HTTP client for announcement tips
Why
Announcement prewarming disabled proxy discovery to avoid the macOS sandbox
panic fixed by #16670.
What changed
RouteAwareClientPoolinsteadof a blocking
reqwestclient.HttpClientFactoryinto prewarming so announcementrequests honor the configured outbound proxy policy.