Preserve approvals reviewer when forking threads - #34664
Merged
copyberry[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
## Why Forking a persisted thread could lose its approvals reviewer and fall back to configuration defaults. ## What changed - Restore the latest persisted approvals reviewer from the full source history when creating a fork, while continuing to honor explicit overrides. - Keep boundary-based history truncation independent from reviewer restoration, so a fork at an earlier turn retains the source thread's latest setting. ## Testing - Add an app-server test that sets auto-review, forks at an earlier turn, and verifies the fork reports auto-review. GitOrigin-RevId: 41c515755de7de600f71c1259f96908f2d169ca7
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/41c515755de7de600f71c1259f96908f2d169ca7
branch
from
July 22, 2026 02:48
880795e to
cefcffd
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/41c515755de7de600f71c1259f96908f2d169ca7
branch
July 22, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve approvals reviewer when forking threads
Why
Forking a persisted thread could lose its approvals reviewer and fall back to
configuration defaults.
What changed
when creating a fork, while continuing to honor explicit overrides.
so a fork at an earlier turn retains the source thread's latest setting.
Testing
verifies the fork reports auto-review.