Migrate login HTTP construction to HttpClient - #34643
Merged
copyberry[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
## Why `codex-http-client` is the intended owner of direct `reqwest` usage. ## What changed - Build Codex's default and route-aware clients with `HttpClientBuilder`, and return `HttpClient` directly to API, model discovery, auth, remote control, skills, and extension callers. - Preserve custom CA, proxy, Cloudflare cookie, sandbox, and request-logging policies while removing `codex-login`'s direct `reqwest` dependency. - Use shared HTTP types for auth headers, status codes, transport errors, and login-server tests. ## Testing - Add a Linux integration test verifying that a regular Responses API turn traverses the configured system proxy. GitOrigin-RevId: 714695fb80762d2083e2f7a6414183e2b3b63854
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/714695fb80762d2083e2f7a6414183e2b3b63854
branch
from
July 22, 2026 00:51
13dfe77 to
539c0e1
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/714695fb80762d2083e2f7a6414183e2b3b63854
branch
July 22, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate login HTTP construction to
HttpClientWhy
codex-http-clientis the intended owner of directreqwestusage.What changed
HttpClientBuilder, and returnHttpClientdirectly to API, model discovery, auth, remote control, skills, and extension callers.codex-login's directreqwestdependency.Testing